dongjoon-hyun commented on a change in pull request #26864: [SPARK-30236][SQL][DOCS] Clarify date and time patterns supported in docs URL: https://github.com/apache/spark/pull/26864#discussion_r357806287
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ########## @@ -654,7 +660,15 @@ case class DateFormatClass(left: Expression, right: Expression, timeZoneId: Opti * Deterministic version of [[UnixTimestamp]], must have at least one parameter. */ @ExpressionDescription( - usage = "_FUNC_(expr[, pattern]) - Returns the UNIX timestamp of the given time.", + usage = "_FUNC_(timeExp[, format]) - Returns the UNIX timestamp of the given time.", + arguments = """ + Arguments: + * timeExp - A date/timestamp or string which is returned as a UNIX timestamp. + Default value is current time Review comment: What do you mean by `Default value is current time` here? Also, `.` is missing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
