viirya commented on a change in pull request #26838: [SPARK-30144][ML][PySpark]
Make MultilayerPerceptronClassificationModel extend MultilayerPerceptronParams
URL: https://github.com/apache/spark/pull/26838#discussion_r357861769
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
##########
@@ -273,29 +274,35 @@ object MultilayerPerceptronClassifier
* Each layer has sigmoid activation function, output layer has softmax.
*
* @param uid uid
- * @param layers array of layer sizes including input and output layers
* @param weights the weights of layers
*/
@Since("1.5.0")
class MultilayerPerceptronClassificationModel private[ml] (
@Since("1.5.0") override val uid: String,
- @Since("1.5.0") val layers: Array[Int],
@Since("2.0.0") val weights: Vector)
extends ProbabilisticClassificationModel[Vector,
MultilayerPerceptronClassificationModel]
- with Serializable with MLWritable {
+ with MultilayerPerceptronParams with Serializable with MLWritable {
Review comment:
Not related to this change. But do we use
MultilayerPerceptronClassificationModel in executors? Like not every
classification model extends Serializable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
