southernriver opened a new pull request #26888: [SPARK-30260][SQL] Spark-Shell throw ClassNotFoundException exception for more than one statement to use UDF jar URL: https://github.com/apache/spark/pull/26888 <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html 2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'. 4. Be sure to keep the PR description updated to reflect all changes. 5. Please write your PR title to summarize what this PR proposes. 6. If possible, provide a concise example to reproduce the issue for a faster review. --> ### What changes were proposed in this pull request? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. 2. If you fix some SQL features, you can provide some references of other DBMSes. 3. If there is design documentation, please add the link. 4. If there is a discussion in the mailing list, please add the link. --> When we start spark-shell and use the udf for the first statement ,it's ok. But for the other statements it failed to load jar to current classpath and would throw ClassNotFoundException.It seems like that the first ClassLoader is different from the other's. For Spark-shell, the maintained class loader is always IMainsTranslatingClassLoader ,and for addJar Operation, the current classLoader is NonClosableMutuableclassLoader. For the first statement, there jar was loaded to right classLoader,and for other statements, the jar has been registered to functionRegistry and would not reload to NonClosableMutuableclassLoader, we need to reset classloader to active sparkSession's. Here, I will show difference between the first statement and the second. First statement is NonClosableMutuableclassLoader: <img width="1073" alt="image" src="https://user-images.githubusercontent.com/20614350/70844299-05c71d00-1e7a-11ea-8457-9d9510b97ecc.png";> Second statement is IMainsTranslatingClassLoader: <img width="883" alt="image" src="https://user-images.githubusercontent.com/20614350/70844323-648c9680-1e7a-11ea-8411-38899661373a.png";> ### Why are the changes needed? <!-- --> The problem can be reproduced as described in the below. ``` scala> val res = spark.sql("select bigdata_test.Add(1,2)").show() ---------------------- |bigdata_test.Add(1, 2)| ---------------------- | 3| ---------------------- scala> val res = spark.sql("select bigdata_test.Add(1,2)").show() org.apache.spark.sql.AnalysisException: No handler for UDF/UDAF/UDTF 'scala.didi.udf.Add': java.lang.ClassNotFoundException: scala.didi.udf.Add; line 1 pos 8 at scala.reflect.internal.util.AbstractFileClassLoader.findClass(AbstractFileClassLoader.scala:62) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at org.apache.spark.sql.hive.HiveShim$HiveFunctionWrapper.createFunction(HiveShim.scala:251) at org.apache.spark.sql.hive.HiveSimpleUDF.function$lzycompute(hiveUDFs.scala:56) at org.apache.spark.sql.hive.HiveSimpleUDF.function(hiveUDFs.scala:56) at org.apache.spark.sql.hive.HiveSimpleUDF.method$lzycompute(hiveUDFs.scala:60) at org.apache.spark.sql.hive.HiveSimpleUDF.method(hiveUDFs.scala:59) at org.apache.spark.sql.hive.HiveSimpleUDF.dataType$lzycompute(hiveUDFs.scala:77) at org.apache.spark.sql.hive.HiveSimpleUDF.dataType(hiveUDFs.scala:77) at org.apache.spark.sql.hive.HiveSessionCatalog$$anonfun$makeFunctionExpression$3.apply(HiveSessionCatalog.scala:79) at org.apache.spark.sql.hive.HiveSessionCatalog$$anonfun$makeFunctionExpression$3.apply(HiveSessionCatalog.scala:71) at scala.util.Try.getOrElse(Try.scala:79) at org.apache.spark.sql.hive.HiveSessionCatalog.makeFunctionExpression(HiveSessionCatalog.scala:71) at org.apache.spark.sql.catalyst.catalog.SessionCatalog$$anonfun$org$apache$spark$sql$catalyst$catalog$SessionCatalog$$makeFunctionBuilder$1.apply(SessionCatalog.scala:1133) ``` After fix: ``` scala> val res = spark.sql("select bigdata_test.Add(1,2)").show() +----------------------+ |bigdata_test.Add(1, 2)| +----------------------+ | 3| +----------------------+ scala> val res = spark.sql("select bigdata_test.Add(1,2)").show() +----------------------+ |bigdata_test.Add(1, 2)| +----------------------+ | 3| +----------------------+ ``` we should resolve this bug! ### Does this PR introduce any user-facing change? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If no, write 'No'. --> No ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> manual.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/20614350/70844299-05c71d00-1e7a-11ea-8457-9d9510b97ecc.png"](https://user-images.githubusercontent.com/20614350/70844299-05c71d00-1e7a-11ea-8457-9d9510b97ecc.png"){kind=link}
![https://user-images.githubusercontent.com/20614350/70844323-648c9680-1e7a-11ea-8411-38899661373a.png"](https://user-images.githubusercontent.com/20614350/70844323-648c9680-1e7a-11ea-8411-38899661373a.png"){kind=link}