HyukjinKwon commented on a change in pull request #26896: [PYSPARK][MINOR][DOC]
fix pyspark slice documentation
URL: https://github.com/apache/spark/pull/26896#discussion_r357980142
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1973,6 +1973,11 @@ def slice(x, start, length):
"""
Collection function: returns an array containing all the elements in `x`
from index `start`
(array indices start at 1, or from the end if `start` is negative) with
the specified `length`.
+
+ :param x: the array to be sliced
+ :param start: the starting index
+ :param length: the length of the slice
Review comment:
Okay, that's fine but can you at least update R and Scala APIs too to be
consistent? You can add new params for start and length at
https://github.com/apache/spark/blob/master/R/pkg/R/functions.R#L213 and add
`@param`s at
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L3267-L3272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
