srowen commented on a change in pull request #26891: Fix issue where
`newFilesOnly` does nothing
URL: https://github.com/apache/spark/pull/26891#discussion_r357980789
##########
File path:
streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala
##########
@@ -185,7 +185,7 @@ class FileInputDStream[K, V, F <: NewInputFormat[K, V]](
lastNewFileFindingTime = clock.getTimeMillis()
// Calculate ignore threshold
- val modTimeIgnoreThreshold = math.max(
+ val modTimeIgnoreThreshold = math.min(
Review comment:
This looks wrong -- see comment above. Surely it is making sure the
threshold is no _earlier_ than either of them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]