vanhooser commented on a change in pull request #26884: [SPARK-30257] [PySpark] 
Add simpleString map
URL: https://github.com/apache/spark/pull/26884#discussion_r357983058
 
 

 ##########
 File path: python/pyspark/sql/types.py
 ##########
 @@ -1603,6 +1627,13 @@ def convert(self, obj, gateway_client):
         t.setNanos(obj.microsecond * 1000)
         return t
 
+
+def from_simple_string(simple_str):
 
 Review comment:
   When scanning over a DataFrame’s columns, I very often use `dtypes()` to get 
both column and type info. 
   
   Therefore, if I want to take this information and create more columns or 
synthesize other dataframes, I have to map from simpleString to actual type 
manually. 
   
   This leads me to make dictionaries in many places that do what’s contained 
in this PR. This will make it much easier. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to