Github user chenghao-intel commented on the pull request:

    https://github.com/apache/spark/pull/4520#issuecomment-73911621
  
    LGTM in general except some of the minor issues.
    
    My original thought on this, is adding a new `Project` on top of the 
`MultiInstanceRelation`(if it appears more than once in the query tree), so we 
can still keep the same reference to the original instance, this probably give 
us an opportunity to optimize the query by only computing once for the 
`MultiInstanceRelation`. 
    
    Anyway, let's leave it for the future improvement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to