cloud-fan commented on a change in pull request #26434: [SPARK-29544] [SQL]
optimize skewed partition based on data size
URL: https://github.com/apache/spark/pull/26434#discussion_r358059427
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/ReduceNumShufflePartitionsSuite.scala
##########
@@ -59,8 +59,9 @@ class ReduceNumShufflePartitionsSuite extends SparkFunSuite
with BeforeAndAfterA
case (bytesByPartitionId, index) =>
new MapOutputStatistics(index, bytesByPartitionId)
}
+ val length = mapOutputStatistics.map(_.bytesByPartitionId.length).head
val estimatedPartitionStartIndices =
- rule.estimatePartitionStartIndices(mapOutputStatistics)
+ rule.estimatePartitionStartAndEndIndices(mapOutputStatistics).unzip._1
Review comment:
we also need to check there is no excluded partitions here, e.g. the end
index = next start index - 1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
