Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4460#issuecomment-73927224
@mengxr Great, that helps me. I took another shot at implementing the above
ideas.
- Is package `org.apache.spark.ml.attribute` reasonable?
- `FeatureType` duplicates
`org.apache.spark.mllib.tree.configuration.FeatureType`; OK as this will be the
'new' version?
- `Metadata` operates like a `Map`, and that means keys don't necessarily
have a value. Does it need to return `Option[...]` from its methods then?
- You can see there's some special handling of optional values in the
caller when buildilng too. Should the builder accept `Option[...]` too?
- I'm not sure I implemented the patterns quite in the way you had in mind,
like regarding `producer`. Please comment if you prefer a different design
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
