srowen commented on a change in pull request #26911: Remove usage of Guava that
breaks in 27; replace with workalikes
URL: https://github.com/apache/spark/pull/26911#discussion_r358414571
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java
##########
@@ -144,10 +145,10 @@ public Object convertToNetty() throws IOException {
@Override
public String toString() {
- return Objects.toStringHelper(this)
- .add("file", file)
- .add("offset", offset)
- .add("length", length)
+ return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE)
Review comment:
The format of the toString is a bit different after this. Before (Guava):
`Foo{bar=baz, bing=3}` After (Commons Lang3): `Foo[bar=baz,bing=3]`. I think
the exact format is not important for these classes though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
