vanzin commented on a change in pull request #26895: [SPARK-17398][SQL] Fix
ClassCastException when querying partitioned JSON table
URL: https://github.com/apache/spark/pull/26895#discussion_r358531513
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala
##########
@@ -252,10 +254,14 @@ class HadoopTableReader(
partProps.asScala.foreach {
case (key, value) => props.setProperty(key, value)
}
- deserializer.initialize(hconf, props)
+ DeserializerLock.synchronized {
+ deserializer.initialize(hconf, props)
+ }
// get the table deserializer
val tableSerDe =
localTableDesc.getDeserializerClass.getConstructor().newInstance()
- tableSerDe.initialize(hconf, localTableDesc.getProperties)
+ DeserializerLock.synchronized {
+ tableSerDe.initialize(hconf, tableProperties)
Review comment:
What you have is ok but you can completely avoid this second serde instance;
in the common case both `localDeserializer` and
`localTableDesc.getDeserializerClass` will be the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
