WangGuangxin commented on issue #26899: [SPARK-28332][SQL] Reserve init value -1 only when do min max statistics in SQLMetrics URL: https://github.com/apache/spark/pull/26899#issuecomment-566445278 > shall we update `SQLMetric.merge` to exclude -1 values? We don't need to exclude -1 in `SQLMetric.merge` since it use `o.value` which will not return -1. But we need to check in `SQLMetric.add` and `SQLMetric.+=` to make sure that `_value` is not -1, otherwise, the metric is smaller than real value.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
