HyukjinKwon commented on a change in pull request #26922: [MINOR][SQL][DOC] Fix 
some ambiguous descriptions and format issue in Dataset API Doc
URL: https://github.com/apache/spark/pull/26922#discussion_r358766008
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -2498,6 +2503,10 @@ class Dataset[T] private[sql](
    *
    * Use [[summary]] for expanded statistics and control over which statistics 
to compute.
    *
+   * @note String columns will be implicitly cast to double when performing 
operations like mean
 
 Review comment:
   But this applies to all other stddev and mean functions too:
   
   ```scala
   scala> sql("select mean('1.0')").show()
   +------------------------+
   |avg(CAST(1.0 AS DOUBLE))|
   +------------------------+
   |                     1.0|
   +------------------------+
   ```
   
   I would locate the note in a better place to deduplicate the documentation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to