cloud-fan commented on a change in pull request #26899: [SPARK-28332][SQL]
Reserve init value -1 only when do min max statistics in SQLMetrics
URL: https://github.com/apache/spark/pull/26899#discussion_r358767487
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
##########
@@ -205,7 +210,8 @@ object SQLMetrics {
// directly without setting an execution id. We should be tolerant to it.
if (executionId != null) {
sc.listenerBus.post(
- SparkListenerDriverAccumUpdates(executionId.toLong, metrics.map(m =>
m.id -> m.value)))
+ SparkListenerDriverAccumUpdates(
+ executionId.toLong, metrics.map(m => m.id -> m.getRawValue())))
Review comment:
which driver side metrics use -1 as initial value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
