Ngone51 commented on a change in pull request #26938: [SPARK-30297][CORE] Fix
executor lost in net cause app hung upp
URL: https://github.com/apache/spark/pull/26938#discussion_r360373455
##########
File path: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala
##########
@@ -199,6 +200,18 @@ private[spark] class HeartbeatReceiver(sc: SparkContext,
clock: Clock)
if (now - lastSeenMs > executorTimeoutMs) {
logWarning(s"Removing executor $executorId with no recent heartbeats:
" +
s"${now - lastSeenMs} ms exceeds timeout $executorTimeoutMs ms")
+ sc.schedulerBackend match {
+ case backend: CoarseGrainedSchedulerBackend =>
+ backend.synchronized {
+ // Mark executor pending to remove if executor heartbeat expired
+ // to avoid reschedule task on this executor again
+ if (!backend.executorsPendingToRemove.contains(executorId)) {
+ backend.executorsPendingToRemove(executorId) = false
Review comment:
I think this does not resolve the issue completely. Because when you look
into `sc.killAndReplaceExecutor` below, you can see that we've already mark it
as "pending to remove". Though it happens in another separate thread, but I
don't see big difference according to this issue. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
