HeartSaVioR commented on a change in pull request #26960:
[SPARK-28144][SPARK-29294][SQL][SS] Upgrade the version of Kafka to 2.4
URL: https://github.com/apache/spark/pull/26960#discussion_r360386582
##########
File path:
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/mocks/MockScheduler.scala
##########
@@ -41,57 +42,33 @@ import org.apache.kafka.common.utils.Time
*/
private[kafka010] class MockScheduler(val time: Time) extends Scheduler {
- /* a priority queue of tasks ordered by next execution time */
- var tasks = new PriorityQueue[MockTask]()
+ val scheduler = new DeterministicScheduler()
def isStarted: Boolean = true
def startup(): Unit = {}
def shutdown(): Unit = synchronized {
- tasks.foreach(_.fun())
- tasks.clear()
+ scheduler.runUntilIdle()
}
- /**
- * Check for any tasks that need to execute. Since this is a mock scheduler
this check only occurs
- * when this method is called and the execution happens synchronously in the
calling thread.
- * If you are using the scheduler associated with a MockTime instance this
call
- * will be triggered automatically.
- */
- def tick(): Unit = synchronized {
- val now = time.milliseconds
- while(!tasks.isEmpty && tasks.head.nextExecution <= now) {
- /* pop and execute the task with the lowest next execution time */
- val curr = tasks.dequeue
- curr.fun()
- /* if the task is periodic, reschedule it and re-enqueue */
- if(curr.periodic) {
- curr.nextExecution += curr.period
- this.tasks += curr
- }
- }
+ def tick(duration: Long, timeUnit: TimeUnit): Unit = synchronized {
+ scheduler.tick(duration, timeUnit)
}
def schedule(
name: String,
fun: () => Unit,
delay: Long = 0,
period: Long = -1,
- unit: TimeUnit = TimeUnit.MILLISECONDS): Unit = synchronized {
- tasks += MockTask(name, fun, time.milliseconds + delay, period = period)
- tick()
- }
-
-}
-
-case class MockTask(
- val name: String,
- val fun: () => Unit,
- var nextExecution: Long,
- val period: Long) extends Ordered[MockTask] {
- def periodic: Boolean = period >= 0
- def compare(t: MockTask): Int = {
- java.lang.Long.compare(t.nextExecution, nextExecution)
+ unit: TimeUnit = TimeUnit.MILLISECONDS): ScheduledFuture[_] =
synchronized {
+ val runnable = new Runnable {
+ override def run(): Unit = fun()
+ }
+ if(period >= 0) {
+ scheduler.scheduleAtFixedRate(runnable, delay, period, unit)
Review comment:
It doesn't allow to just pass `fun`, but allow `() => fun()` so will use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
