rdblue commented on a change in pull request #26957: [WIP][SPARK-30314] Add
identifier and catalog information to DataSourceV2Relation
URL: https://github.com/apache/spark/pull/26957#discussion_r360562766
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -195,7 +195,7 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
case desc @ DescribeNamespace(catalog, namespace, extended) =>
DescribeNamespaceExec(desc.output, catalog, namespace, extended) :: Nil
- case desc @ DescribeTable(DataSourceV2Relation(table, _, _), isExtended) =>
+ case desc @ DescribeTable(DataSourceV2Relation(table, _, _, _, _),
isExtended) =>
Review comment:
Cases like this could be translated to `DescribeTable(rel:
DataSourceV2Relation, isExtended)`. Then we wouldn't need to change this
matcher every time the relation changes. Might be a good idea to rewrite it
that way now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
