Eric5553 commented on issue #26977: [SPARK-30326][SQL] Raise exception if analyzer exceed max iterations URL: https://github.com/apache/spark/pull/26977#issuecomment-568542023 @cloud-fan Good catch! IMO, literally the description `The max number of iterations the analyzer runs.` infers we should try to iterate the plan to the maxIteration inclusively with no error or warning. But the current code will raise exception or log warning at the max iteration even the plan is fixed. This apply to both analyzer & optimizer. I tried to fix it in 015e97218b60da907e49ad9bebb208a276a13354, and also added a corresponding test case in RuleExecutorSuite. The case will fail(raise exception) with original code. What's your opinion? Please correct me if I'm wrong. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
