HeartSaVioR opened a new pull request #26992: [SPARK-30337][SQL][SS] Change case class with vars to normal class in spark-sql-kafka module URL: https://github.com/apache/spark/pull/26992 ### What changes were proposed in this pull request? This patch changes case classes with vars to normal classes in spark-sql-kafka module, as it is allowed to use var in case class but discouraged. Quoting https://docs.scala-lang.org/tour/case-classes.html > You can’t reassign message1.sender because it is a val (i.e. immutable). It is possible to use vars in case classes but this is discouraged. ### Why are the changes needed? That was from review comment (https://github.com/apache/spark/pull/22138#discussion_r302304877 / https://github.com/apache/spark/pull/22138#discussion_r302305192) and we have TODO comments to address later. It's time to address it and remove TODO comments. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Existing UTs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
