ulysses-you commented on a change in pull request #26875: [SPARK-30245][SQL]
Add cache for Like and RLike when pattern is not static
URL: https://github.com/apache/spark/pull/26875#discussion_r361128974
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -240,11 +245,16 @@ case class RLike(left: Expression, right: Expression)
extends StringRegexExpress
}
} else {
val rightStr = ctx.freshName("rightStr")
- val pattern = ctx.freshName("pattern")
+ val pattern = ctx.addMutableState(patternClass, "pattern")
+ val lastRightStr = ctx.addMutableState(classOf[String].getName,
"lastRightStr")
+
nullSafeCodeGen(ctx, ev, (eval1, eval2) => {
s"""
String $rightStr = $eval2.toString();
- $patternClass $pattern = $patternClass.compile($rightStr);
+ if ($rightStr != $lastRightStr) {
Review comment:
Yes, forget this is not scala code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
