ulysses-you commented on a change in pull request #27008: [SPARK-30353][SQL]
Use constraints in SimplifyBinaryComparison optimization
URL: https://github.com/apache/spark/pull/27008#discussion_r361344683
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -115,6 +114,7 @@ abstract class Optimizer(catalogManager: CatalogManager)
Batch("Infer Filters", Once,
InferFiltersFromConstraints) ::
Batch("Operator Optimization after Inferring Filters", fixedPoint,
+ Seq(SimplifyBinaryComparison) ++
Review comment:
We should apply `InferFiltersFromConstraints` first and then apply
`SimplifyBinaryComparison` to retain `isnotnull` filter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
