Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4567#discussion_r24580189
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/ApplicationInfo.scala ---
@@ -79,6 +81,7 @@ private[spark] class ApplicationInfo(
val exec = new ExecutorDesc(newExecutorId(useID), this, worker, cores,
desc.memoryPerSlave)
executors(exec.id) = exec
coresGranted += cores
+ coresMax = if(coresGranted > coresMax) coresGranted else coresMax
--- End diff --
Might be able to use `math.max` here. Also should the column heading say
"Cores (max)" in the case of completed apps only? Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
