HeartSaVioR commented on a change in pull request #27010: [SPARK-30313][CORE]
Ensure EndpointRef is available MasterWebUI/WorkerPage
URL: https://github.com/apache/spark/pull/27010#discussion_r361370210
##########
File path:
core/src/main/scala/org/apache/spark/deploy/worker/ui/WorkerPage.scala
##########
@@ -33,7 +33,12 @@ import org.apache.spark.ui.{UIUtils, WebUIPage}
import org.apache.spark.util.Utils
private[ui] class WorkerPage(parent: WorkerWebUI) extends WebUIPage("") {
- private val workerEndpoint = parent.worker.self
+ private val workerEndpoint = {
Review comment:
Same here: if we don't feel comfortable adding infinite loop, we can just
change it from val to def, with adding comment it shouldn't be cached.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
