maropu commented on a change in pull request #26863: [SPARK-30234]ADD FILE
cannot add directories from sql CLI
URL: https://github.com/apache/spark/pull/26863#discussion_r361432542
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2098,6 +2098,12 @@ object SQLConf {
"defined by `from` and `to`.")
.booleanConf
.createWithDefault(false)
+
+ val ADD_DIRECTORY_USING_RECURSIVE =
buildConf("spark.sql.addDirectory.recursive")
+ .doc(" When true, users can add directory by passing path of a directory
to ADD FILE" +
+ "command of SQL. If false, then only a single file can be added.")
+ .booleanConf
+ .createWithDefault(false)
Review comment:
If so, how about following that?; just adding an option under
`spark.sql.legacy.xxx` then enabling it by default. Also, we need to update the
migration guide, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
