HyukjinKwon commented on a change in pull request #26589: [SPARK-29947][SQL]
Improve ResolveRelations performance
URL: https://github.com/apache/spark/pull/26589#discussion_r361595210
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -847,21 +847,32 @@ class Analyzer(
case _ => plan
}
- def apply(plan: LogicalPlan): LogicalPlan =
ResolveTempViews(plan).resolveOperatorsUp {
- case i @ InsertIntoStatement(table, _, _, _, _) if i.query.resolved =>
- val relation = table match {
- case u @ UnresolvedRelation(SessionCatalogAndIdentifier(catalog,
ident)) =>
- lookupRelation(catalog, ident, recurse = false).getOrElse(u)
- case other => other
- }
+ def apply(plan: LogicalPlan): LogicalPlan = {
+ var logicalPlans = Map.empty[UnresolvedRelation, LogicalPlan]
Review comment:
Why don't you use a mutable map while we're here? Also, can you add a short
comment with the JIRA ID?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
