cloud-fan commented on a change in pull request #26868: [SPARK-29665][SQL]
refine the TableProvider interface
URL: https://github.com/apache/spark/pull/26868#discussion_r361610186
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
##########
@@ -173,15 +173,13 @@ final class DataStreamReader private[sql](sparkSession:
SparkSession) extends Lo
case _ => None
}
ds match {
- case provider: TableProvider =>
+ // file source v2 does not support streaming yet.
Review comment:
file source v2 is never supported in streaming, as `FileTable.capabilities`
doesn't include streaming ones.
The reason I check it earlier is: now we call `TableProvider.inferSchema`
before checking table capabilities, and the error becomes different if `path`
is not specified.
It's weird that file source reports different error between batch and
streaming when path is not specified. We should unify it. Here I just don't
want to be blocked by an existing problem. cc @gengliangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
