jiangxb1987 commented on a change in pull request #27017: [SPARK-30359][CORE]
Don't clear executorsPendingToRemove at the beginning of
CoarseGrainedSchedulerBackend.reset
URL: https://github.com/apache/spark/pull/27017#discussion_r361768905
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1894,4 +1903,60 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
assert(sched.taskSetsFailed.contains(taskSet.id))
}
+
+ test("SPARK-30359: Don't clear executorsPendingToRemove in
CoarseGrainedSchedulerBackend.reset")
+ {
+ val conf = new SparkConf()
+ // use local-cluster mode in order to get CoarseGrainedSchedulerBackend
+ .setMaster("local-cluster[2, 1, 2048]")
+ // allow to set up at most two executors
+ .set("spark.cores.max", "2")
Review comment:
why do we still need this config?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
