zhengruifeng commented on issue #26483: [SPARK-29823][MLLIB] Improper persist strategy in mllib.clustering.KMeans.run() URL: https://github.com/apache/spark/pull/26483#issuecomment-569480169 @srowen @amanomer Do we need this change? `data: RDD[Vector]` and `norms: RDD[Double]` are both cached, `zippedData` just involved extra cost of convert vectors to VectorWithNorms. Do this help improving performace? I donot see any performance result. on the contrary, this will cause double caching problem: Since vectors are already cached in the .ml or maybe outside of the `run` method, but never used.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
