Github user chipsenkbeil commented on a diff in the pull request:
https://github.com/apache/incubator-toree/pull/104#discussion_r121751667
--- Diff:
kernel/src/test/scala/org/apache/toree/kernel/protocol/v5/relay/ExecuteRequestRelaySpec.scala
---
@@ -88,7 +89,7 @@ class ExecuteRequestRelaySpec extends TestKit(
// Expected does not actually match real return of magic, which
// is a tuple of ExecuteReply and ExecuteResult
val expected = new ExecuteAborted()
- interpreterActorProbe.expectMsgClass(
+ interpreterActorProbe.expectMsgClass(max = Duration(5,
TimeUnit.SECONDS),
--- End diff --
Rather than hard coding the duration to 5 seconds, we should have a
constant somewhere defined to that duration. Furthermore, I'm trying to
remember how akka's testkit time scaling works. I honestly can't remember, but
we want to make sure that it does indeed scale according to our config. I think
testkit does that for us, so this should be fine, but we probably need to
double-check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
