Github user chipsenkbeil commented on a diff in the pull request:
https://github.com/apache/incubator-toree/pull/104#discussion_r121751964
--- Diff:
kernel/src/test/scala/org/apache/toree/kernel/protocol/v5/stream/KernelInputStreamSpec.scala
---
@@ -65,6 +65,9 @@ class KernelInputStreamSpec
// set of data
doReturn(system.actorSelection(fakeInputOutputHandlerActor.path.toString))
.when(mockActorLoader).load(MessageType.Incoming.InputReply)
+ // Allow time for the actors to start. This avoids read() hanging
forever
+ // when running tests in gradle.
+ Thread.sleep(100)
--- End diff --
I _really_ dislike `sleep` calls. Is there any better way to do this? Is
there any flag or way to know when the actors have started and use a future,
callback, or something here rather than a thread sleep?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
