adamantal commented on a change in pull request #96: [YUNIKORN-72] data race in
unit test: TestTaskStateTransitions
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/96#discussion_r403920836
##########
File path: pkg/conf/schedulerconf.go
##########
@@ -68,12 +70,12 @@ type SchedulerConf struct {
}
func GetSchedulerConf() *SchedulerConf {
- return configuration
+ return (*SchedulerConf)(atomic.LoadPointer(&pointer))
}
// unit tests may need to override configuration
func Set(conf *SchedulerConf) {
Review comment:
As far as I can see, we do not import this function - so we can use `set`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
