yangwwei commented on a change in pull request #96: [YUNIKORN-72] data race in
unit test: TestTaskStateTransitions
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/96#discussion_r405929733
##########
File path: pkg/conf/schedulerconf.go
##########
@@ -45,7 +47,7 @@ const (
DefaultKubeBurst = 1000
)
-var configuration *SchedulerConf
+var pointer unsafe.Pointer
Review comment:
Thanks, @adamantal @wilfred-s
this a fair point, I removed unsafe pkg used in this patch. Instead, using a
lock and get/set approach.
Since the conf object is global, I think we should not replace the object
anytime, just stick to update or get values.
Please see my latest commit. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
