adamantal commented on pull request #143:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/143#issuecomment-628715036


   > I think we need to distinguish between two sets of constants:
   > 
   > * shared between shim(s) and core
   > * shim or core specific constants
   > 
   > Any constant that is used as a key in messages that flow between the shim 
and the core should be in the SI. Constants that are used as values should not 
be in the SI. Each part can set its own defaults and we should not mix that 
into the specification for the messages.
   > 
   > As an example: rack name information
   > 
   > * the key that specifies the rack name attribute should be in the SI
   > * the default value should _not_ be in the SI
   
   I don't see any scheduler-local constants here, so I keep this PR as it is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to