wilfred-s commented on a change in pull request #152:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/152#discussion_r428457006



##########
File path: pkg/scheduler/tests/scheduler_reservation_test.go
##########
@@ -382,6 +383,86 @@ func TestAddNewNode(t *testing.T) {
        assert.Equal(t, 0, ms.getPartitionReservations()[appID], "reservations 
not removed from partition")
 }
 
+// simple reservation one app one queue
+func TestUnReservationAndDeletion(t *testing.T) {

Review comment:
       It crashed for me and the logs show that the ask is removed before the 
allocation is processed. If that does not happen the allocation will be 
confirmed. The checks at the end of the test case should not return no 
allocations on the nodes as they are not in the correct state etc.
   That would cause the test case to fail.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to