wilfred-s commented on a change in pull request #152:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/152#discussion_r432487377



##########
File path: pkg/scheduler/tests/scheduler_reservation_test.go
##########
@@ -382,6 +383,86 @@ func TestAddNewNode(t *testing.T) {
        assert.Equal(t, 0, ms.getPartitionReservations()[appID], "reservations 
not removed from partition")
 }
 
+// simple reservation one app one queue
+func TestUnReservationAndDeletion(t *testing.T) {

Review comment:
       Running multiple times only lowers the chance of that happening but it 
still does not guarantee that the events come in correctly. The only way that 
could be done is to stop part of the handling or manipulating the objects 
directly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to