[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #173: [YUNIKORN-231] Add ability to update pod condition based on accurate scheduling state

[GitBox]

yangwwei commented on a change in pull request #173:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/173#discussion_r450716573



##########
File path: pkg/scheduler/scheduling_queue_test.go
##########
@@ -827,3 +1118,157 @@ func TestIsEmpty(t *testing.T) {
        leaf.addSchedulingApplication(app)
        assert.Equal(t, leaf.isEmpty(), false, "queue with registered app 
should not be empty")
 }
+
+func TestGetOutstandingRequest(t *testing.T) {
+       const app1ID = "app1"
+       const app2ID = "app1"

Review comment:
       we can add more tests for `app.getOutstandingRequests()`, but this is 
covering more code paths by including the queue, I suggest to keep it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org