wilfred-s commented on a change in pull request #173:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/173#discussion_r451999291
##########
File path: pkg/scheduler/scheduling_queue.go
##########
@@ -482,9 +482,26 @@ func (sq *SchedulingQueue) getHeadRoom()
*resources.Resource {
if sq.parent != nil {
parentHeadRoom = sq.parent.getHeadRoom()
}
+ return sq.internalHeadRoom(parentHeadRoom)
+}
+
+// this function returns the max headRoom of a queue
+// this doesn't get the partition resources into the consideration
+func (sq *SchedulingQueue) getMaxHeadRoom() *resources.Resource {
Review comment:
You cannot solve this without the changes as proposed in #173.
Without that making any changes here does not help. So no, it just will not
work correctly in a queue hierarchy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
