yangwwei commented on a change in pull request #192:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/192#discussion_r492425324
##########
File path: deployments/yunikorn-application/application-definition.yaml
##########
@@ -50,14 +50,40 @@ spec:
spec:
type: object
properties:
- minMember:
- type: integer
+ appId:
+ type: string
+ policy:
+ type: object
+ properties:
+ policy:
+ type: string
+ timeout:
+ type: integer
+ retrySecond:
+ type: integer
queue:
type: string
pattern: '^[a-zA-Z0-9_-]{1,64}([.]{1}[a-zA-Z0-9_-]{1,64})*$'
- maxPendingSeconds:
- type: integer
- minimum: 1
+ taskGroups:
+ type: array
+ items:
+ type: object
+ properties:
+ name:
+ type: string
+ minMember:
+ type: integer
+ minResource:
+ type: object
+ properties:
+ cpu:
+ type: integer
+ format: int32
+ minimum: 1
+ memory:
+ type: integer
+ format: int32
+ minimum: 1
Review comment:
this should support other resource types, other than cpu and memory
could u pls check how resources is being set in `pod` and I think we should
do the similar thing here.
the format is not supposed to be `int32`, see more in
https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#resource-units-in-kubernetes.
##########
File path: deployments/yunikorn-application/sample-yunikorn-app.yaml
##########
@@ -20,5 +20,19 @@ kind: Application
metadata:
name: example
spec:
+ appId: "app0001"
Review comment:
I think we need to remove this.
Earlier we concluded to use "namespace"-"app-CRD-name" as the `appID`, which
is unique within the cluster.
##########
File path: deployments/yunikorn-application/application-definition.yaml
##########
@@ -50,14 +50,40 @@ spec:
spec:
type: object
properties:
- minMember:
- type: integer
+ appId:
+ type: string
+ policy:
+ type: object
+ properties:
+ policy:
+ type: string
+ timeout:
+ type: integer
+ retrySecond:
+ type: integer
Review comment:
I think this should be a map that supports arbitrary key-value pairs.
because different policies will have different parameter names, and values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
