kingamarton commented on a change in pull request #192:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/192#discussion_r493461020
##########
File path: deployments/yunikorn-application/sample-yunikorn-app.yaml
##########
@@ -20,5 +20,19 @@ kind: Application
metadata:
name: example
spec:
+ appId: "app0001"
Review comment:
I agree. But I think we should publish the appID. Right now, the
definition does not have any appID field. I think it will be very useful to
publish it. Right now the used doesn't know the appId after submitting the CRD.
He/she will have to check the webUI or to recall it from the docs/code that it
is in the form of namespace-name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
