kingamarton commented on pull request #202: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/202#issuecomment-718173194
> where misses `PodFitsHost`. Even you add this one, I still have some concern there might be something out of our radar, could you please take a closer look at the predicates functions and let me know if this is a safe change? Predicates are invoked in every scheduling cycle, we need to be extremely careful while making changes. Oh, you are right. I mixed it with the `PodFitsPorts`. I added the missing predicate and also checked the functions. The same functions are called. I found only one minor difference. With this approach, we will return in case of the first predicate failure, and while using GeneralPredicates all the predicates are checked and all the failures are collected. However I don't consider this one an important difference, because in case of the other predicates the behaviour is the same: only the first failure is returned. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
