yangwwei commented on pull request #202: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/202#issuecomment-718470143
hi @kingamarton another difference I noticed: ``` // GeneralPredicates checks whether noncriticalPredicates and EssentialPredicates pass. noncriticalPredicates are the predicates // that only non-critical pods need and EssentialPredicates are the predicates that all pods, including critical pods, need ``` if we remove `GeneralPred`, that means we are running all these predicates for every pod, no matter they are critical or non-critical, this could be a behavior change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
