kingamarton commented on a change in pull request #219:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/219#discussion_r542330862
##########
File path: pkg/common/configs/configvalidator.go
##########
@@ -75,65 +75,100 @@ func checkACL(acl string) error {
// Check the queue resource configuration settings.
// - child or children cannot have higher maximum or guaranteed limits than
parents
// - children (added together) cannot have a higher guaranteed setting than a
parent
-func checkResourceConfigurationsForQueue(cur *QueueConfig, parent
*QueueConfig) error {
+func checkResourceConfigurationsForQueue(cur QueueConfig, parentMax
*resources.Resource, parentGuaranteed *resources.Resource) error {
Review comment:
Removed repeated parameter type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
