kingamarton commented on a change in pull request #219:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/219#discussion_r542347516
##########
File path: pkg/common/resources/resources.go
##########
@@ -771,6 +803,13 @@ func IsZero(zero *Resource) bool {
return true
}
+func IsEmpty(r *Resource) bool {
+ if r == nil {
+ return true
+ }
+ return len(r.Resources) == 0
+}
+
Review comment:
Removed this method and extended isZero check with checking if the
resources are empty and if yes handle it as zero resource
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
