wilfred-s commented on a change in pull request #229:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/229#discussion_r570017028
##########
File path: deployments/examples/gang/cmd/gangDeploy.sh
##########
@@ -26,46 +26,23 @@ set -o pipefail
JOBAMOUNT=$1
GANGMEMBER=$2
RUNTIMESEC=$3
Review comment:
We really need to check and fail if there are not enough parameters.
We also should check if the parameters are integers with a simple check:
```
if [ "$1" -eq "$1" ] 2>/dev/null
then
JOBAMOUNT=$1
else
echo "ERROR: first parameter must be an integer."
exit 1
fi
```
##########
File path: deployments/examples/gang/cmd/gangDeploy.sh
##########
@@ -96,5 +73,6 @@ spec:
value: "$RUNTIMESEC"
restartPolicy: Never
schedulerName: yunikorn
-EOF)
+EOF
+)
done
Review comment:
Please add a newline here too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
