yangwwei commented on a change in pull request #229:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/229#discussion_r570503288
##########
File path: deployments/examples/gang/cmd/gangDeploy.sh
##########
@@ -26,46 +26,22 @@ set -o pipefail
JOBAMOUNT=$1
GANGMEMBER=$2
RUNTIMESEC=$3
+TIMEOUT=0
+
+# create service and job counter web server
+WORKDIR=$(cd "$(dirname "$0")"; pwd)
+kubectl apply -f $WORKDIR/../gang-coordinator.yaml
Review comment:
I mean to check the file existence in the code, e.g
```
if [[ -f $WORKDIR/../gang-coordinator.yaml ]]; then
// do something
else
// print the error message and return
fi
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
