wilfred-s commented on a change in pull request #229:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/229#discussion_r571951694
##########
File path: deployments/examples/gang/cmd/gangDeploy.sh
##########
@@ -96,5 +73,6 @@ spec:
value: "$RUNTIMESEC"
restartPolicy: Never
schedulerName: yunikorn
-EOF)
+EOF
+)
done
Review comment:
After the done. The check for "no newline at the end of file" is always
for the last line of the file. It expects a simple empty line at the end of the
file, like this:
```
EOF)
done
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
