HuangTing-Yao commented on a change in pull request #229:
URL: 
https://github.com/apache/incubator-yunikorn-k8shim/pull/229#discussion_r571990846



##########
File path: deployments/examples/gang/cmd/gangDeploy.sh
##########
@@ -96,5 +73,6 @@ spec:
           value: "$RUNTIMESEC"
       restartPolicy: Never
       schedulerName: yunikorn
-EOF)
+EOF
+)
 done

Review comment:
       OK, done, but we can't put the `)` after `EOF` in same line.
   It will show some warning, need to put it in next line.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to