HuangTing-Yao commented on a change in pull request #243:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/243#discussion_r598585372
##########
File path: pkg/common/constants/constants.go
##########
@@ -55,7 +55,7 @@ const AppManagerHandlerName = "yunikorn-app"
const PlaceholderContainerImage = "k8s.gcr.io/pause"
const PlaceholderContainerName = "pause"
const PlaceholderPodRestartPolicy = "Never"
-const AnnotationPlaceholderFlag = "yunikorn.apache.org/placeholder"
+const PlaceholderFlag = "yunikorn.apache.org/placeholder"
Review comment:
Sure, follow the some rule will more clear to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
