HuangTing-Yao commented on a change in pull request #243:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/243#discussion_r598586211
##########
File path: pkg/common/utils/gang_utils.go
##########
@@ -75,7 +75,7 @@ func GetPlaceholderResourceRequest(resources
map[string]resource.Quantity) v1.Re
}
func GetPlaceholderFlagFromPodSpec(pod *v1.Pod) bool {
- if value, ok := pod.Annotations[constants.AnnotationPlaceholderFlag];
ok {
+ if value, ok := pod.Annotations[constants.PlaceholderFlag]; ok {
Review comment:
I think we can follow the same logic in `GetApplicationIDFromPod()`, add
the label part in `GetPlaceholderFlagFromPodSpec()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
