kingamarton commented on a change in pull request #260:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/260#discussion_r632525911
##########
File path: pkg/cache/application.go
##########
@@ -107,13 +107,13 @@ func NewApplication(appID, queueName, user string, tags
map[string]string, sched
Src: []string{states.Running},
Dst: states.Running},
{Name: string(events.ReleaseAppAllocation),
- Src: []string{states.Failed},
+ Src: []string{states.Failing},
Review comment:
I think this transition is not correct. Let's say we have an application
with 3 allocations. The app will be moved into the Failed state right after
removing the first allocation. We want to have the app Failed only when
everything is cleared and no allocations and asks are left.
##########
File path: pkg/cache/application.go
##########
@@ -107,13 +107,13 @@ func NewApplication(appID, queueName, user string, tags
map[string]string, sched
Src: []string{states.Running},
Dst: states.Running},
{Name: string(events.ReleaseAppAllocation),
- Src: []string{states.Failed},
+ Src: []string{states.Failing},
Dst: states.Failed},
{Name: string(events.ReleaseAppAllocationAsk),
Src: []string{states.Running, states.Accepted,
states.Reserving},
Dst: states.Running},
{Name: string(events.ReleaseAppAllocationAsk),
- Src: []string{states.Failed},
+ Src: []string{states.Failing},
Review comment:
The same here as for the ReleaseAppAllocation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
